perf: hard link local recovery archive - #13494
Merged
Merged
Conversation
ssongliu
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses LOCAL snapshot restore failures for large archives by avoiding a time-limited file copy during the “Download snapshot file” step.
Changes:
- Add explicit error handling for
NewBackupClientWithIDso restore doesn’t proceed/log with an invalid backup account. - For LOCAL backup accounts, attempt to hard-link the snapshot archive into the recovery workspace before falling back to
client.Download.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+274
to
+280
| func prepareSnapshotRecoverFile(accountType, sourcePath, targetPath string, download func() error) error { | ||
| if accountType == constant.Local { | ||
| if err := os.Link(sourcePath, targetPath); err == nil { | ||
| return nil | ||
| } | ||
| } | ||
| return download() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #13490